Repository navigation
feat(client): bring the Hero's particle background into the workspace - #16
Merged
Merged
Conversation
Mount the shared BackgroundLayer behind WorkspaceShell so the authenticated /app views get the same ambient effect as the Hero, /login, and /register, per explicit request. Readability of the dense workspace UI is preserved deliberately: - WorkspaceShell's header gets a frosted (bg/70 + backdrop-blur) treatment instead of a flat opaque background, so nav/user controls stay legible over the animated canvas. - ProjectList's project cards already sit on solid surfaces and need no change. - WorkspaceGraphView's title bar and graph canvas get the same frosted-card treatment as the Hero's own GraphStage (bg-background-elevated/60 + backdrop-blur), since React Flow's dot-grid background is otherwise transparent and would let particles bleed straight through the graph. Also fixes a test gap surfaced by this change: jsdom has no matchMedia implementation, so any component using useReducedMotion (BackgroundLayer's dependency) throws in tests unless it's mocked. Added a shared mock to vitest.setup.ts rather than per-test, since it's a jsdom environment gap, not something specific to this component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mount the shared BackgroundLayer behind WorkspaceShell so the authenticated /app views get the same ambient effect as the Hero, /login, and /register, per explicit request. Readability of the dense workspace UI is preserved deliberately:
Also fixes a test gap surfaced by this change: jsdom has no matchMedia implementation, so any component using useReducedMotion (BackgroundLayer's dependency) throws in tests unless it's mocked. Added a shared mock to vitest.setup.ts rather than per-test, since it's a jsdom environment gap, not something specific to this component.